Hi Gaetan, On Tue, Nov 26, 2013 at 07:02:23PM -0500, Gaetan Nadon wrote: > On 13-11-26 06:33 PM, Ran Benita wrote: > > This was already committed, but how about changing to AC_CC_C99 instead? > Pardon me as I am out of context. The xserver module is configured with > AC_PROG_CC_C99 that gets pulled in by XORG_DEFAULTS from util-macros. > It's not obvious, but it saves from copying this line in the 250 xorg > modules.
Problem is, xcb doesn't use util-macros. I like it myself. > That's why we ask developers not to add AC_PROG_CC in configure.ac as it > turns the module back to C89. That isn't obvious either :-) > > To find which of the two a module is using: > > grep "^CC=" config.status > > and you get: > > CC='gcc -std=gnu99' > > > There are also a couple of options to fine tune the level of strictness: > > --disable-selective-werror > Turn off selective compiler errors. (default: > enabled) Didn't know about this one, used to do this manually sometimes. > --enable-strict-compilation > Enable all warnings from compiler and make > them > errors (default: disabled) > > I took this opportunity to explain this non obvious configuration to all. > > pedantic _can_ be useful for XCB imo, e.g. the "enum too big for an int" > > thing. Also, the code already uses some C99 constructs now. > > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
