Peter Hutterer <[email protected]> writes:

> This patch changes the behavior, so that the brackets are always the nearest
> positive or negative transitions to the current counter value. In the example
> above, nt will trigger a wakeup and a re-calculation of the brackets, so that
> going past it in the negative direction will then cause the proper alarm
> triggers.

I couldn't quite figure out Peter's example, but I do understand the
patch and it looks correct. It fixes cases like:

        Timer currently past a positive trigger

                No bracket values, because no trigger in range

        Timer moves backwards before the positive trigger

                Brackets not reset, even though there is now a trigger
                in range

        Timer moves forward past the positive trigger

                Trigger doesn't fire because brackets not set
        
Setting the LT bracket in this case will cause everything to get
re-evaluated when the sync value moves backwards before the trigger
value.

Reviewed-by: Keith Packard <[email protected]>

-- 
[email protected]

Attachment: pgp2cVeeGx8xg.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to