On 22/10/2012 19:59, Yaakov (Cygwin/X) wrote:
> From: Yaakov Selkowitz 
> <[email protected]>
> 
> Private is a struct member name in mingw-w64 <winioctl.h>, causing this
> useless define in a private header to break the build.

This hunk has wrong whitespace

> diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
> index c047715..1860162 100644
> --- a/modules/im/ximcp/imRmAttr.c
> +++ b/modules/im/ximcp/imRmAttr.c
> @@ -859,7 +859,7 @@ _XimEncodeIMATTRIBUTE(
>  }
>  
>  #ifdef XIM_CONNECTABLE
> -Public       Bool
> +     Bool
>  _XimEncodeSavedIMATTRIBUTE(
>      Xim                       im,
>      XIMResourceList   res_list,

With that fixed, Reviewed-by: Jon TURNEY <[email protected]>

Yes, I read the whole thing.

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to