On Aug 29, 2012, at 16:08, Peter Hutterer <[email protected]> wrote:
> On Wed, Aug 29, 2012 at 09:22:16AM -0700, Jeremy Huddleston Sequoia wrote: >> diff --git a/include/list.h b/include/list.h >> index d54a207..edf10ba 100644 >> --- a/include/list.h >> +++ b/include/list.h >> @@ -26,6 +26,12 @@ >> #ifndef _XORG_LIST_H_ >> #define _XORG_LIST_H_ >> >> +#ifdef HAVE_DIX_CONFIG_H >> +#include "dix-config.h" >> +#endif > > shouldn't this be included by whatever requires the list header? a git grep > for HAVE_DIX_CONFIG_H in include only shows two headers using it, and it's > likely neither of them should. > > Reviewed-by: Peter Hutterer <[email protected]> to the rest of the > patch Yeah. I'm slightly worried about the case where someone might accidentally forget to include dix-config.h, but I'm fine leaving it out. Thanks, Jeremy _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
