On Thu, 28 Jun 2012 12:07:11 +1000, Christopher James Halse Rogers <[email protected]> wrote: > The legacy logic was embarassingly wrong; AuthMagic should return errno, > so returning FALSE only when AuthMagic returns nonzero is exactly wrong. > > v2: Match drmAuthMagic by returning -EINVAL rather than EINVAL > Fix trailing whitespace > > https://bugs.freedesktop.org/show_bug.cgi?id=51400 > Signed-off-by: Christopher James Halse Rogers > <[email protected]> > --- > > v2 is not immediately necessary; the sole place that uses this only checks > for zero/non-zero. Matching the rest of the return values will certainly > make it less surprising should this change, however.
My earlier tested-by stands for this patch as well, Tested-by: Chris Wilson <[email protected]> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
