Hi, On 27 June 2012 17:04, Michal Srb <[email protected]> wrote: > +void * > +LoaderSymbolFromModule(const char *name, void *handle) > +{ > + return dlsym(handle, name); > +}
As a nitpick, I'd expect this to be LoaderSymbolFromModule(handle, name) - and had wrote this even before I noticed that dlsym had the arguments that way around too. It just seems like a more logical order. That aside: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
