Dave Airlie <[email protected]> writes: > + pScrn->origIndex = pScrn->scrnIndex; /* This never changes */
I can't find any users of origIndex; I suspect it can be safely removed. > - xf86Screens[i]->drv = drv; > + pScrn->drv = drv; > drv->refCount++; > - xf86Screens[i]->module = DuplicateModule(drv->module, NULL); > + pScrn->module = DuplicateModule(drv->module, NULL); > > - xf86Screens[i]->DriverFunc = drv->driverFunc; > + pScrn->DriverFunc = drv->driverFunc; > > - return xf86Screens[i]; > + return pScrn; > } bikeshed -- would it be better to clean up the xf86Screens[i] usage before adding gpu screen support? Otherwise, this one looks good to me Reviewed-by: Keith Packard <[email protected]> -- [email protected]
pgpMhSjp999fi.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
