On Tue, 2012-06-19 at 14:38 -0400, Kristian Høgsberg wrote: > On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard <[email protected]> wrote: > > Christopher James Halse Rogers <[email protected]> > > writes: > > > >> +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t > >> magic); > > > > Bikeshed -- seems like the 'fd' parameter is not needed in this API? > > I'll note that in the implementation of the wrapper, you pull it from > > the screen private instead of using the provided parameter... > > Oh, that is a good point, I like that bikeshed color better. >
Technically I pull it from the DRI2Srceen private, which the driver
won't have access to, but {intel,nouveau,ati} also store this fd in
their driver private, so it's not a problem for them.
I'll send a blue-painted patch. :)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
