This patch caused a build regression: http://tinderbox.x.org/builds/2012-05-15-0003/logs/xserver/#build
enterleave.c: In function 'DeviceFocusOutEvents': enterleave.c:618:9: error: implicit declaration of function 'DeviceFocusEvent' [-Werror=implicit-function-declaration] enterleave.c:618:9: warning: nested extern declaration of 'DeviceFocusEvent' [-Wnested-externs] You removed the redundant DeviceFocusEvent(), but you didn't first make sure it was provided. The fix should be including exevents.h in enterleave.h (for consistency with 369edd78769fa1a174e4091d0fa0722350df5d68). --Jeremy commit 31174565ec0090b4c03c9334c82878be2455f938 Author: Michal Suchanek <[email protected]> Date: Wed Apr 25 15:03:31 2012 +0200 dix: Remove redundant declarations. Signed-off-by: Michal Suchanek <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Signed-off-by: Dave Airlie <[email protected]> On Apr 25, 2012, at 9:14 AM, Michal Suchanek <[email protected]> wrote: > On 24 April 2012 20:44, Chase Douglas <[email protected]> wrote: > >> Hi Michal, >> >> Either your email client or my thunderbird is munging the patch >> attachments. They aren't coming across correctly here. >> >> However, even if they were, it is hard to review patches as attachments. >> Please send them as individual emails. You can use git send-email to do >> this, for example. > > Unfortunately, site restrictions would not allow to send bulk email > using git send-email or similar. > > Attaching 20+ files to a single email is not optimal either I guess. > >> >> Further, it may be time for you to have commit access on >> git.freedesktop.org so you can push a tree up with your fixes. That >> would make it easier for others to pull the fixes and test them out. > > I exported updated version of these patches at > > http://repo.or.cz/w/xserver/hramrach.git/shortlog/refs/heads/noredecl > > or branch noredecl of git://repo.or.cz/xserver/hramrach.git > > Thanks > > Michal > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel > _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
