On Tue, 15 May 2012 17:56:33 +0100, Dave Airlie <[email protected]> wrote:
> On Tue, May 15, 2012 at 4:16 PM, Keith Packard <[email protected]> wrote:
> > On Mon, 14 May 2012 13:00:20 +0100, Dave Airlie <[email protected]> wrote:
> >
> >> -    /* if this is called during ScreenInit() we don't have pScrn->pScreen 
> >> yet */
> >> -    ScreenPtr pScreen = screenInfo.screens[pScrn->scrnIndex];
> >> +    ScreenPtr pScreen = xf86ScrnToScreen(pScrn);
> >
> > I assume your fine new macro doesn't have a problem with pScrn->pScreen
> > not being set yet?
> 
> Well currently they just do lookups in the global arrays in a
> function, so we don't have to worry,

Ok, as long as said global arrays are initialized before these
uses. I'll take a look at that code and see if I can follow it.

> I'd plan on embedding ScreenRec into ScrnInfoRec at some point in the
> distant future,

Obviously the right plan. Just making sure the transition continues to
work as well as the current code.

-- 
[email protected]

Attachment: pgpjrw6oStMOS.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to