On 17/02/2012 06:41, Jeremy Huddleston wrote: > For both: > Reviewed-by: Jeremy Huddleston <[email protected]> > > On Feb 15, 2012, at 8:32 PM, Peter Hutterer <[email protected]> wrote: > >> This reverts commit bbb6b8c834e0e1491ca14403b5d0840dd14380d3. >> >> With this patch applied, Xorg -retro does not display the default cursor. >> >> Cause: IsFloating(dev) returns 1 for a master device if that master device >> is not yet paired with the keyboard. This happens for the VCP at startup, >> causing the above issue. >> >> Correct fix is to replace with "!IsMaster() && IsFloating()". >> >> Reported-by: Colin Harrison <[email protected]> >> Reported-by: Jon TURNEY <[email protected]> >> Signed-off-by: Peter Hutterer <[email protected]> >> --- >> I'm sending this as a revert + a new patch to make future cherry-picking >> easier.
Thanks for looking at this, on behalf of all the people who like to run their 1989 style windowing system inside a window on their contemporary windowing system :-) This fixes the proximate issue of no default cursor with Xwin -retro, so Tested-by: Jon TURNEY <[email protected]> However, I have to report that this doesn't fix things when I try testing it with Xorg (with the vesa driver on virtualbox). This might well be something I'm doing wrong, as I guess you can't reproduce this being introduced with dc57f89, but only with bbb6b8c. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
