On 12-01-06 11:24 AM, Colin Walters wrote: > On Fri, 2012-01-06 at 10:52 -0500, Gaetan Nadon wrote: >> Very little has changed in this one. > Your commit message isn't helpful - *what* are you simplifying? In this > case it looks like you're e.g. putting -I directives in CPPFLAGS, using > the common $(DRM_CFLAGS), and alphabetizing the sources. Say so then, > something like: > > lib: Fix include directives, alphabetize sources > > -I should go in AM_CPPFLAGS. You are absolutely right, I got lazy. I'll review all of them. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
- [PATCH intel-gpu-tools 0/6] Convert debugger to Automake Gaetan Nadon
- [PATCH intel-gpu-tools 1/6] Debugger: convert existing ... Gaetan Nadon
- Re: [PATCH intel-gpu-tools 1/6] Debugger: convert e... Colin Walters
- Re: [PATCH intel-gpu-tools 1/6] Debugger: conve... Gaetan Nadon
- Re: [PATCH intel-gpu-tools 1/6] Debugger: c... Colin Walters
- [PATCH intel-gpu-tools 2/6] Benchmark: simplify makefil... Gaetan Nadon
- [PATCH intel-gpu-tools 3/6] lib: simplify makefile Gaetan Nadon
- Re: [PATCH intel-gpu-tools 3/6] lib: simplify makef... Colin Walters
- Re: [PATCH intel-gpu-tools 3/6] lib: simplify m... Gaetan Nadon
- [PATCH intel-gpu-tools 4/6] scripts: use PYTHON primary... Gaetan Nadon
- [PATCH intel-gpu-tools 5/6] tools: minor compiler flags... Gaetan Nadon
- [PATCH intel-gpu-tools 6/6] config: remove unused AC_DE... Gaetan Nadon
