On Wed, Jan 04, 2012 at 08:41:25PM +0100, Mark Kettenis wrote: > > Date: Wed, 4 Jan 2012 19:01:31 +0000 > > From: Daniel Stone > > > > Hi, > > > > > If Daniel Kurtz's analysis of the problem is right, and I believe it > > > is, then this diff is just as wrong as the previous diff from Peter. > > > It also means that the real culprit is Peter's change to constify > > > XIChangeDeviceProperty(). ??While Daniel Kurtz's suggestion to > > > introduce a cpointer typedef would work, I think it's better to drop > > > the pointer typedef entirely and simply use "const void *" in the > > > XIChangeDeviceProperty() prototype. ??We should probably deprecate the > > > pointer typedef; I bet the reason it was introduced was to support > > > pre-ANSI C, and I think we all agree that's irrelevant now. > > > > I never saw Daniel's analysis, > > http://lists.x.org/archives/xorg-devel/2012-January/028243.html > > > but even if it's true, we'll need to fix it somehow for this ABI > > version anyway, and while the patch may not be excruciatingly > > correct per se, it's certainly safe for the usage. > > The change I'm suggesting won't affect the ABI in any way.
Isn't a change from 'void const *' to the intended 'const void *', which is what a XIChangeDeviceProperty() fix would comprise, technically ABI? not that it really matters in this case, imo. Cheers, Peter _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
