This doesn't break XQuartz, but it reveals that we actually don't call LogClose when we probably should be now.
That being said, it looks like you missed some... ~/src/freedesktop/src/xserver-1.11 (master) $ ack LogClose hw/xfree86/common/xf86Helper.c 1203: LogClose(error); hw/xwin/InitOutput.c 231: LogClose (); 904: LogClose (); hw/xwin/winerror.c 84: LogClose (); include/os.h 518:extern _X_EXPORT void LogClose(enum ExitCode error); os/log.c 234:LogClose(enum ExitCode error) On Jul 25, 2011, at 15:06, Peter Hutterer wrote: > On Mon, Jul 25, 2011 at 09:28:53AM +0100, Daniel Stone wrote: >> On Wed, Jul 20, 2011 at 01:17:43PM +1000, Peter Hutterer wrote: >>> Instead of just closing the log when everything is done, put one more >>> message in stating that we're actually terminating. Users or scripts that >>> look at the Xorg.log will then know that a) the server has terminated >>> properly and b) why the server terminated (to some degree, given that most >>> real-world errors will be caused by AbortServer()). >>> >>> Signed-off-by: Peter Hutterer <[email protected]> >> >> Reviewed-by: Daniel Stone <[email protected]> > > Thanks. Jeremy, can you let this patch go through your tree, just so we're > sure it didn't break XQuartz. > Jon, if you could test this for XWin too that'd be much appreciated. > > Cheers, > Peter > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel > _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
