On 02/12/11 02:13 PM, Mark Kettenis wrote:
>> From: Adam Jackson <[email protected]>
>> Date: Sun, 23 Jan 2011 23:18:07 -0500
>>
>> It's broken for devices with BARs above 4G, and the sysfs method should
>> work everywhere anyway. As a pleasant side effect, this fixes some
>> warnings:
>>
>> fbdevhw.c: In function 'fbdev_open_pci':
>> fbdevhw.c:333:4: warning: cast from pointer to integer of different size
>> fbdevhw.c:334:4: warning: cast from pointer to integer of different size
>> fbdevhw.c:336:4: warning: cast from pointer to integer of different size
>> fbdevhw.c:337:4: warning: cast from pointer to integer of different size
>>
>> Signed-off-by: Adam Jackson <[email protected]>
>
> That code should really be #ifdef __linux__ to make it obvious that it
> is OS-specific code. Anyway, if the Linux community is happy with it,
> I am as well ;).
The entire fbdevhw.c is Linux-specific. fbdevhwstubs.c is for the rest of us.
The "if" is just in the configure.ac & Makefile.am, not the C code.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
