On 02/01/2011 10:03 AM, ext Alan Coopersmith wrote:
On 01/31/11 04:02 AM, Erkki Seppälä wrote:
From: Ander Conselvan de Oliveira<[email protected]>
xcms/LRGB: Add a label for freeing property_return.
That's a much better subject/shortlog line than the far too long one you have
there now.
I agree with you and I actually wrote the commit message that way. Looks
like Erkki changed it for some reason.
@@ -789,8 +782,6 @@ LINEAR_RGB_InitSCCData(
#endif /* ALLDEBUG */
}
- Xfree ((char *)property_return);
-
/* Free the old memory and use the new structure created. */
LINEAR_RGB_FreeSCCData(pPerScrnInfo->screenData);
Don't you need to leave that one there since you return(XcmsSuccess);
in that case, without going down through the Free* / return(XcmsFailure) path?
I guess I got carried away with all the search and replace. I'll send a
corrected version with the original commit message.
Thanks,
Ander
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
