On 01/31/11 04:01 AM, Erkki Seppälä wrote: > Variable "fs" not freed or pointed-to in function "get_prop_name" > > Reviewed-by: Ander Conselvan de Oliveira > <[email protected]> > Signed-off-by: Erkki Seppälä <[email protected]> > --- > src/xlibi18n/XDefaultOMIF.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/src/xlibi18n/XDefaultOMIF.c b/src/xlibi18n/XDefaultOMIF.c > index bc6b1b9..bb3986a 100644 > --- a/src/xlibi18n/XDefaultOMIF.c > +++ b/src/xlibi18n/XDefaultOMIF.c > @@ -398,7 +398,10 @@ get_font_name( > if (fs == NULL) return NULL; > > prop_name = get_prop_name(dpy, fs); > - if (prop_name == NULL) return NULL; > + if (prop_name == NULL) { > + XFreeFont(dpy, fs); > + return NULL; > + }
The indenting is inconsistent there and should be fixed, but for the code itself: Reviewed-by: Alan Coopersmith <[email protected]> -- -Alan Coopersmith- [email protected] Oracle Solaris Platform Engineering: X Window System _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
