On 27.01.2011 10:30, Alan Coopersmith wrote:
      prop->name= (char *)_XkbAlloc(strlen(name)+1);
-    if (!name)
-       return NULL;
      strcpy(prop->name,name);
      prop->value= (char *)_XkbAlloc(strlen(value)+1);
      if (!value) {
Looks like that should instead be checking if (!prop->name) to
make sure the alloc didn't fail.   Same for the following
if (!value) instead of if(!prop->value).

Indeed. I have a v2 patch waiting :).
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to