On Fri, Nov 26, 2010 at 4:34 PM, Jesse Adkins <[email protected]> wrote: > I had to backspace after the 'char' and before '**reasonMsgs' to get > this to apply. Perhaps the git repo has been updated since this patch. > Aside from that, it applies. > > Can you comment on why this is needed, either in the code or in the > git commit? Is there anything that can be done to trigger this leak? I > have no problem with giving this a test, but I've never heard of a > leak in libSM when running X in valgrind mode or using it on clients. > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel
Is it proper convention to cast arguments to free() as char* in this lib? I'd rather just leave it uncasted. Shutting up Valgrind is always important, even if the leak in question is trivial. Reviewed-by: Corbin Simpson <[email protected]> -- When the facts change, I change my mind. What do you do, sir? ~ Keynes Corbin Simpson <[email protected]> _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
