Jamey Sharp <[email protected]> (12/11/2010): > Oh, wait. You don't need the conditionals or the lookup_ret variable > here at all: the result pointer is already guaranteed to be NULL if > the return value is not Success.
I guess dix/deprecated.c should be adjusted accordingly, then? > I guess I'm willing to stick my reviewed-by on these warning fixes > either way, but I'd prefer to not add the unnecessary checks. I can resend a series without those. > Also, you might consider casting the first argument of > dixLookupResourceBy* to (pointer*), rather than (pointer). The > compiler doesn't care since they're both compatible with (void*), > but (pointer*) is better documentation. Will include that in the next series. Mraw, KiBi.
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
