The Open Group documentation for Select does not mention it failing with EAGAIN.
http://opengroup.org/onlinepubs/007908775/xsh/select.html Even so, we check for this error after Select is called in WaitForSomething. Anybody knows why? In case that check was just a mistake, here's a fix.
>From 7f615aa4f441471979c1a5e090d09cbd019f57d0 Mon Sep 17 00:00:00 2001 From: Fernando Carrijo <[email protected]> Date: Tue, 3 Aug 2010 17:19:47 -0300 Subject: [PATCH] os: Select can not fail with EAGAIN. Don't check for it in WaitForSomething. Signed-off-by: Fernando Carrijo <[email protected]> --- os/WaitFor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/os/WaitFor.c b/os/WaitFor.c index e663004..c625937 100644 --- a/os/WaitFor.c +++ b/os/WaitFor.c @@ -248,7 +248,7 @@ WaitForSomething(int *pClientsReady) FatalError("WaitForSomething(): select: %s\n", strerror(selecterr)); } - else if (selecterr != EINTR && selecterr != EAGAIN) + else if (selecterr != EINTR) { ErrorF("WaitForSomething(): select: %s\n", strerror(selecterr)); -- 1.7.0.4
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
