On Sat, 8 May 2010 11:54:30 +0200 (CEST), Mark Kettenis <[email protected]> wrote:
> > +#if 0
> > case CT_PIXMAP:
> > case CT_UNSORTED:
> > case CT_YSORTED:
> > @@ -390,6 +391,7 @@ void dmxChangeClip(GCPtr pGC, int type, pointer pvalue,
> > int nrects)
> > /* These clip types are condensed down to either NONE or REGION
> > in the mi code */
> > break;
> > +#endif
> > }
>
> This one is really odd. What compiler warning does this "fix"?
The bitfield in the GC isn't wide enough to hold these values.
> > - if (fbconfigId == NULL && visual == NULL) {
> > + if (fbconfigId == 0 && visual == 0) {
> > return BadValue;
> > }
>
> Shouldn't this be None here instead of NULL/0?
Good point, yes they should be.
--
[email protected]
pgpGHJCTmh5NX.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
