On Wed, 21 Apr 2010 18:28:13 +0300, Tiago Vignatti <[email protected]> wrote: > This issue was introduced in the first dump of the code in 2004. I haven't > check what's the correct fix for it so I simply kept the behaviour of someone > calling this and removed the unreachable code. > > Signed-off-by: Tiago Vignatti <[email protected]> > --- > Keith, this patch is the last in my queue of Coverity findings. I sent twice > and no one commented so far, so I'm expecting an answer from the RM > now.
Yeah, I looked at the code and your patch seems fine; this driver polls the hardware until the tuner locks or gives up, recording the result in last_afc_hint, so it seems correct to simply return the most recently received value. Reviewed-by: Keith Packard <[email protected]> -- [email protected]
pgp8qA0TesKHm.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
