Mikhail Gusarov wrote:
> +    if (!setenv("WINDOWPATH", newwindowpath, TRUE))
> +        fprintf(stderr, "%s:  unable to set WINDOWPATH\n", program);

When I built and tried running it, this always reported a bogus error
until I changed it to:
    if (setenv("WINDOWPATH", newwindowpath, TRUE) != 0)
        Error("unable to set WINDOWPATH");

since setenv() on Solaris at least returns 0 for success, -1 for failure.

Other than that, with the entire series of 14 applied, everything seemed
to build and work fine, and the code changes looked good on review, so

Reviewed-by: Alan Coopersmith <[email protected]>

-- 
        -Alan Coopersmith-        [email protected]
         Oracle Solaris Platform Engineering: X Window System

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to