On Tue, Apr 13, 2010 at 1:20 AM, Julien Cristau <[email protected]> wrote: > On Tue, Apr 13, 2010 at 11:25:54 +1000, Peter Hutterer wrote: > >> Run git describe on build and push the output into xorg-git-version.h. Then >> print that out in the logfile. >> >> Signed-off-by: Peter Hutterer <[email protected]> >> --- >> Do we want something like this? Suggestions for less dodgy implementations >> are welcome, but the current one passes distcheck. >> > If this goes in, I'd like a way to disable it so I don't get "unknown > version" in all logs. I already put the package version in the > builderstring so the version info is there. Maybe just print this if > PRE_RELEASE?
One way to make that happen easily is to make the script just not define XORG_GIT_VERSION when it can't get the describe output instead of making the version "Unknown...". Then for a tarball, you'll just get no string in the log that says "git version: ...". I have some other comments on the implementation if this is something people want. I think that as long as it doesn't show up in tarball builds, I'm all for it. It will be a really nice to find out where people are at if they're trying development builds. -- Dan _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
