Sorry for the delay, I was quite busy this time...

I'm worried about EvdevAddAbsClass getting a bit too messy with this. If I'm
not mistaken, you can quite trivially move this if (flags&  MULTITOUCH)
condition into a EvdevMTCountValuators() and the loop to init all axes into a
EvdevMTInitValuators(). I think in the future MT will need some more special
handling so refacturing it out into a nice "namespace" might aid this.

Bonus point - you could easily add some documentation to those about the
approach evdev takes in handling multitouch events.

If you squash the preceding patch into this one, then that would be one nice
logic.

will do

Cheers,
Benjamin


code-wise ACK so if you could just do that minor change and the comments,
then I'll push it.

Cheers,
   Peter

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to