Hello, I attempted to send this patch to the SIS USB driver author as listed in the sources, and since I was unable to recieve a reply I am forwarding it to this list in hopes that it can be applied to the driver source by a maintainer. Please see the message below for comments on what the patch fixes.
I am not subscribed to this list so any replies should be sent back to me directly. -- Burton Samograd ---------- Forwarded message ---------- From: Burton Samograd <[email protected]> Date: Thu, Mar 25, 2010 at 2:31 PM Subject: SIS USB Driver Patch To: [email protected] Hello Thomas, I noticed that you are the developer and maintainer of the SIS USB Xorg driver. I am reading the source code to learn about Xorg driver development, and I think I came across a minor bug in the code during the initialization phase (in SISUSBProbe). I have attached a patch which should fix the problem. It is short and should be self explanitory; it seems that when you were calling xf86ClaimNoSlot you were using the wrong index into the devSections array. The patch stores the correct index while doing the device probe and uses it to reference the correct devSection when claiming the slot. I am new to Xorg driver development but this looked like a clear enough problem that I should attempt to fix it. Hopefully my solution is correct and it can be applied to the driver code. I am currently reading version 0.9.3 of the driver code. If you are not the current maintainer of the driver, could you please direct me towards the new maintainer so I can attempt to send them this patch? Thank you. -- Burton Samograd [email protected]
sisusb_driver.c.diff-u.patch
Description: Binary data
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
