On Mon, Dec 28, 2009 at 18:00:28 +0200, Tiago Vignatti wrote: > This reverts commit da923d0bc15e99a8ed1986bd6f5df37f7af7284b. > > Signed-off-by: Tiago Vignatti <[email protected]> > > --- > Again this Matt's change is breaking my compilation under scratchbox, for arm > architecture: > > then mv -f ".deps/sys.Tpo" ".deps/sys.Plo"; else rm -f ".deps/sys.Tpo"; > exit 1; fi > gcc -DHAVE_CONFIG_H -I. -I../../../../hw/xfree86/x86emu -I../../../include > -I../../../include -I../../../include -I../../../include -I../../../include > -I../../../include -I../../../include -I../../../include > -I../../../../hw/xfree86 -I../../../../hw/xfree86/include > -I../../../../hw/xfree86/common -I../../../../hw/xfree86/os-support > -I../../../../hw/xfree86/os-support/bus -I../../../../os -DPRE_RELEASE=0 > -DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wstrict-prototypes > -Wmissing-prototypes -Wmissing-declarations -Wnested-externs > -fno-strict-aliasing -Wbad-function-cast -Wold-style-definition > -Wdeclaration-after-statement -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT > -DDBUS_API_SUBJECT_TO_CHANGE -I/usr/include/freetype2 -I/usr/include/pixman-1 > -I/usr/include/hal -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include > -I../../../../include -I../../../include -I../../../../Xext > -I../../../../composite -I../../../../damageext -I../../../../xfixes > -I../../../../Xi -I../../../../mi -I../../../../miext/shadow > -I../../../../miext/damage -I../../../../render -I../../../../randr > -I../../../../fb -fvisibility=hidden -DHAVE_XORG_CONFIG_H -fvisibility=hidden > -DXF86PM -Wall -g -O2 -MT sys.lo -MD -MP -MF .deps/sys.Tpo -c > ../../../../hw/xfree86/x86emu/sys.c -fPIC -DPIC -o .libs/sys.o > ../../../../hw/xfree86/x86emu/sys.c: In function 'rdl': > ../../../../hw/xfree86/x86emu/sys.c:143: warning: passing argument 1 of > 'ldl_u' from incompatible pointer type > ../../../../hw/xfree86/x86emu/sys.c: In function 'wrl': > ../../../../hw/xfree86/x86emu/sys.c:225: warning: passing argument 2 of > 'stl_u' from incompatible pointer type > ../../../../hw/xfree86/x86emu/sys.c: In function 'X86EMU_setupPioFuncs': > ../../../../hw/xfree86/x86emu/sys.c:376: error: 'X86EMU_pioFuncs' has no > member named 'xf_outb' > ../../../../hw/xfree86/x86emu/sys.c:377: error: 'X86EMU_pioFuncs' has no > member named 'xf_outw' > ../../../../hw/xfree86/x86emu/sys.c:378: error: 'X86EMU_pioFuncs' has no > member named 'xf_outl' > > > Sorry to not scream before about it, when the patch came to xorg-devel review. > > Now I could try to fix the issue of the patch, but I'm not happy with its > approach: the patch is using a header from the server inside x86emu. There's > no conceptual problem on it but it will complicates when we try to remove > x86emu from the server (my ongoing work - using lrmi). > > So I'd be happy to just revert such patch now. > The reason for the revert should be included in its commit message, imo, not just buried in this email.
Thanks, Julien _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
