Excerpts from Jamey Sharp's message of Thu Oct 01 15:26:47 -0700 2009: > Hmm. I think that's what I did?
Wow. 3 hours of sleep is clearly not good here. Yes, it looks quite reasonable on actual review (and a couple of hours of napping on the plane). > But ProcPanoramiXShmGetImage seems to need an actual array with at least > as many entries as the number of active screens, which it uses as a > temporary. I'd allocate/free at each call. (and, no, not using alloca). > > You then wrap CloseScreen (in the usual way) and free your private > > structure there. > > I missed that step. I wondered whether this stuff was supposed to get > freed somewhere... heh. server 'regen' has quite a number of leaks of this nature. I found a bunch a week ago or so, but it's nice to catch them early :-) -- [email protected]
signature.asc
Description: PGP signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
