> Date: Sun, 4 Oct 2009 12:06:02 +1100 > From: Daniel Stone <[email protected]> > > On Fri, Oct 02, 2009 at 01:42:46PM -0700, Jamey Sharp wrote: > > Signed-off-by: Jamey Sharp <[email protected]> > > --- > > hw/xfree86/int10/helper_exec.c | 28 ++++++++++++++-------------- > > 1 files changed, 14 insertions(+), 14 deletions(-) > >=20 > > diff --git a/hw/xfree86/int10/helper_exec.c b/hw/xfree86/int10/helper_exe= > c.c > > index 6ba647f..38b0adf 100644 > > --- a/hw/xfree86/int10/helper_exec.c > > +++ b/hw/xfree86/int10/helper_exec.c > > @@ -219,7 +219,7 @@ port_rep_inb(xf86Int10InfoPtr pInt, > > register int inc =3D d_f ? -1 : 1; > > CARD32 dst =3D base; > > if (PRINT_PORT && DEBUG_IO_TRACE()) > > - ErrorF(" rep_insb(%#x) %ld bytes at %8.8lx %s\n", > > + ErrorF(" rep_insb(%#x) %" PRId32 " bytes at %8.8" PRIx32 " %s\n", > > port, count, base, d_f ? "up" : "down"); > > while (count--) { > > MEM_WB(pInt, dst, x_inb(port)); > > Is this portable beyond glibc? Alan? Matthieu?
The PRId32 and PRIx32 defines are part of C99. That said, the consensus among many groups of developers is that they are ugly, make the code harder to read and can be easily avoided by using appropriate casts. _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
