On Tue, Aug 25, 2009 at 06:35:31PM -0400, James Cloos wrote: > Now that automake 1.11 has easy support for controling the verbosity of > make, we should make that available. > > Is there any preference for whether silent should be enabled or disabled > by default? Either way, one can override via the --enable-silent-rules > and --disable-silent-rules configure flags or via make V=1 and make V=0, > so this question is only relevant to those who configure and make w/o > specifying a verbosity choice. > > The first step is to add either of: > > m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([no])]) > > or: > > m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])]) > > to configure.ac.
I'd rather have it into xorg-macros. See the patch below as a possible solution to get it for 'free'. > There is also a $(AM_V_GEN) which can be added as a prefix to > Makefile.am command lines to control verbosity for commands which > automake doesn't know about, such as the $(RAWCPP) commands in libX11. > > But that can be done as a separate step, if desired. this is also a reason to put it into the macros to avoid future duplication. > Is there a consensus preference for or against make verbosity? Definitely against make verbosity. (enable-silent-rules yes) It's easy to miss warnings in between current output and I guess the number of times one need to see warnings is significantly higher than the number of times you need to see the exact command. The move to shave by default in the server supports this as well. >From 19fb4008653b24b94eaccaabd442d44da08848ce Mon Sep 17 00:00:00 2001 From: Peter Hutterer <[email protected]> Date: Tue, 25 Aug 2009 09:40:01 +1000 Subject: [PATCH] Add AM_SILENT_RULES to default XORG_CWARNFLAGS Automake 1.11 supports silent builds with the new AM_SILENT_RULES. http://sources.redhat.com/automake/automake.html#Options This loosely qualifies as a CWARNFLAG since it allows all the warnings to be seen and enables modules to gain support from the feature without any changes needed to configure. --- xorg-macros.m4.in | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in index bcf8c44..1954714 100644 --- a/xorg-macros.m4.in +++ b/xorg-macros.m4.in @@ -454,4 +454,5 @@ else fi fi AC_SUBST(CWARNFLAGS) +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) ]) # XORG_CWARNFLAGS -- 1.6.3.rc1.2.g0164.dirty Cheers, Peter _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
