On Thu, Aug 13, 2009 at 3:58 PM, David Miller<[email protected]> wrote:
> From: Matt Turner <[email protected]>
> Date: Thu, 13 Aug 2009 11:55:42 -0400
>
>> Please review the attached patch. Thanks for the input.
>
> What are those branches for?  (this is retorical, I
> know the reason, it's a chip bug workaround)

>From memory: a branch misprediction before an membar could cause bad things.

I'd assume that you wrote both the code and relevant comments in
arch/sparc/include/asm/system_64.h. :)

> If there is a reason to add them, you need to document
> that reason in either the commit message or comments
> in the code.

Sure, good point.

Matt
_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to