On 01.06.21 18:10, Olaf Hering wrote:
xl migrate --debug used to track every pfn in every batch of pages. But these times are gone. Adjust the help text to tell what --debug is supposed to do today.Signed-off-by: Olaf Hering <[email protected]> --- docs/man/xl.1.pod.in | 4 +++- tools/libs/guest/xg_sr_save.c | 2 +- tools/xl/xl_cmdtable.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index e2176bd696..ed3f4dee1e 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -481,7 +481,9 @@ domain.=item B<--debug> -Display huge (!) amount of debug information during the migration process.+Verify transferred domU page data. All memory will be transferred one more +time to the destination host while the domU is paused, and compared with +the result of the inital transfer while the domU was still running.
Shouldn't you adapt (or remove?) this paragraph with patch 37?
=item B<-p> diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.cindex 2ba7c3200c..51542a98c8 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -752,7 +752,7 @@ static int send_domain_memory_live(struct xc_sr_context *ctx) if ( rc ) goto out;- if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN )+ if ( ctx->save.debug )
This is no documentation change IMO. You should either mention this modification in the commit message, or put it into a separate patch. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
