On 21.04.2021 11:11, Roger Pau Monné wrote: > On Thu, Apr 01, 2021 at 11:45:09AM +0200, Jan Beulich wrote: >> While they apparently do no harm when building xen.efi, their use is >> potentially misleading. Conditionalize their use to be for just the ELF >> binary we produce. >> >> No change to the resulting binaries. > > The GNU Linker manual notes that program headers would be ignored when > not generating an ELF file, so I'm not sure it's worth us adding more > churn to the linker script to hide something that's already ignored by > ld already. > > Maybe adding a comment noting program headers are ignored when not > generating an ELF output would be enough?
Maybe, but I'd prefer this to be explicit, and I'd prefer for efi.lds to not have any PE-unrelated baggage. The churn by this patch isn't all this significant, is it? In fact in two cases it actually deletes meaningless stuff. Jan
