On 25/02/2021 17:22, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.15] x86/dmop: Properly fail for PV
> guests"):
>> The current code has an early exit for PV guests, but it returns 0 having
>> done
>> nothing.
> Reviewed-by: Ian Jackson <[email protected]>
Thanks.
>
>> diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
>> index 5bc172a5d4..612749442e 100644
>> --- a/xen/arch/x86/hvm/dm.c
>> +++ b/xen/arch/x86/hvm/dm.c
>> @@ -365,6 +365,7 @@ int dm_op(const struct dmop_args *op_args)
>> if ( rc )
>> return rc;
>>
>> + rc = -EINVAL;
>> if ( !is_hvm_domain(d) )
>> goto out;
> Is this style, of setting rc outside the if, the standard hypervisor
> style ?
If you think the cyclomatic complexity is bad in libxl...
This is the prevailing style in this function. Its common, but not
universal style.
~Andrew
