On 05/02/2021 11:53, Roger Pau Monne wrote: > Bison is now mandatory when the pvshim build is enabled in order to > generate the Kconfig. > > Signed-off-by: Roger Pau Monné <[email protected]> > --- > Please re-run autogen.sh after applying. > > Fallout from this patch can lead to broken configure script being > generated or bison not detected correctly, but those will be cached > quite quickly by the automated testing.
I think this can be simpler. Both flex and bison are mandatory libxlutil. i.e. they should both simply to convert to _OR_FAIL variants in place. ~Andrew > --- > tools/configure.ac | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/configure.ac b/tools/configure.ac > index 5b328700e0..f4e3fccdb0 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -308,7 +308,6 @@ AC_ARG_VAR([AWK], [Path to awk tool]) > AC_PROG_CC > AC_PROG_MAKE_SET > AC_PROG_INSTALL > -AC_PATH_PROG([BISON], [bison]) > AC_PATH_PROG([FLEX], [flex]) > AX_PATH_PROG_OR_FAIL([PERL], [perl]) > AX_PATH_PROG_OR_FAIL([AWK], [awk]) > @@ -516,5 +515,10 @@ AC_ARG_ENABLE([pvshim], > esac > ]) > AC_SUBST(pvshim) > +AS_IF([test "x$pvshim" = "xy"], [ > + AX_PATH_PROG_OR_FAIL([BISON], [bison]) > +], [ > + AC_PATH_PROG([BISON], [bison]) > +]) > > AC_OUTPUT()
