Re: [PATCH] xenstored: close socket connections on error

[Jürgen Groß]

On 04.02.21 12:16, Manuel Bouyer wrote:

On Thu, Feb 04, 2021 at 12:11:02PM +0100, Jürgen Groß wrote:

On 03.02.21 17:54, Manuel Bouyer wrote:

On error, don't keep socket connection in ignored state but close them.
When the remote end of a socket is closed, xenstored will flag it as an
error and switch the connection to ignored. But on some OSes (e.g.
NetBSD), poll(2) will return only POLLIN in this case, so sockets in ignored
state will stay open forever in xenstored (and it will loop with CPU 100%
busy).

Signed-off-by: Manuel Bouyer <bou...@netbsd.org>
Fixes: d2fa370d3ef9cbe22d7256c608671cdcdf6e0083

Reviewed-by: Juergen Gross <jgr...@suse.com>

thanks.
I still don't know if I'm supposed to send a new version of the patch with
these tags, even if the patch itself doesn't change, or if the commiter
will handle them ?

Will be done by the committer.


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

OpenPGP_signature
Description: OpenPGP digital signature