On Wed, Feb 03, 2021 at 12:54:23PM +0100, Jürgen Groß wrote: > On 03.02.21 12:48, Manuel Bouyer wrote: > > On Wed, Feb 03, 2021 at 09:21:32AM +0100, Jürgen Groß wrote: > > > [...] > > > This shouldn't happen in case we are closing the socket actively. > > > > > > In the end we should just do a talloc_free(conn) in > > > ignore_connection() if it is a socket based one. This should revert > > > the critical modification of the XSA-115 fixes for sockets while > > > keeping the desired effect for domain connections. > > > > Hello > > here's an updated patch which works for me. Does anyone see a problem > > with it ? If not I will submit it for commit. > > > > Do you really need the first hunk? I would have thought just freeing > conn in ignore_connection() is enough. > > In case you are seeing problems without the first hunk, please say so > in a comment added to this hunk in order to avoid it being removed > sometimes in the future.
No I don't need it. From your previous comments I though it was a good idea to keep it, but I can remove it if you think it's better. -- Manuel Bouyer <[email protected]> NetBSD: 26 ans d'experience feront toujours la difference --
