On Tue, Jan 12, 2021 at 07:12:28PM +0100, Manuel Bouyer wrote:
> From: Manuel Bouyer <[email protected]>
>
> On NetBSD the privcmd interface node is /kern/xen/privcmd
>
> Signed-off-by: Manuel Bouyer <[email protected]>
> ---
> tools/debugger/gdbsx/xg/xg_main.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/debugger/gdbsx/xg/xg_main.c
> b/tools/debugger/gdbsx/xg/xg_main.c
> index ce95648e7e..83a009c195 100644
> --- a/tools/debugger/gdbsx/xg/xg_main.c
> +++ b/tools/debugger/gdbsx/xg/xg_main.c
> @@ -130,11 +130,11 @@ xg_init()
> int flags, saved_errno;
>
> XGTRC("E\n");
> - if ((_dom0_fd=open("/dev/xen/privcmd", O_RDWR)) == -1) {
> - if ((_dom0_fd=open("/proc/xen/privcmd", O_RDWR)) == -1) {
> - perror("Failed to open /dev/xen/privcmd or /proc/xen/privcmd\n");
> - return -1;
> - }
> + if ((_dom0_fd=open("/dev/xen/privcmd", O_RDWR)) == -1 &&
> + (_dom0_fd=open("/proc/xen/privcmd", O_RDWR)) == -1 &&
> + (_dom0_fd=open("/kern/xen/privcmd", O_RDWR)) == -1) {
Nit: hard tab instead of spaces.
> + perror("Failed to open /dev/xen/privcmd or /proc/xen/privcmd or
> /kern/xen/privcmd\n");
I would have split the line, so:
perror("Failed to open /dev/xen/privcmd or /proc/xen/privcmd or "
"/kern/xen/privcmd\n");
If you can resend with those fixed please add:
Reviewed-by: Roger Pau Monné <[email protected]>
Thanks, Roger.
