On Mon, Dec 14, 2020 at 05:36:12PM +0100, Manuel Bouyer wrote:
> ---
> tools/libs/light/libxl_create.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index 321a13e519..44691010bc 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -496,7 +496,7 @@ int libxl__domain_build(libxl__gc *gc,
> vments[2] = "image/ostype";
> vments[3] = "hvm";
> vments[4] = "start_time";
> - vments[5] = GCSPRINTF("%lu.%02d",
> start_time.tv_sec,(int)start_time.tv_usec/10000);
> + vments[5] = GCSPRINTF("%jd.%02d",
> start_time.tv_sec,(int)start_time.tv_usec/10000);
You don't cast tv_sec to intmax_t here...
>
> localents = libxl__calloc(gc, 13, sizeof(char *));
> i = 0;
> @@ -535,7 +535,7 @@ int libxl__domain_build(libxl__gc *gc,
> vments[i++] = "image/kernel";
> vments[i++] = (char *) state->pv_kernel.path;
> vments[i++] = "start_time";
> - vments[i++] = GCSPRINTF("%lu.%02d",
> start_time.tv_sec,(int)start_time.tv_usec/10000);
> + vments[i++] = GCSPRINTF("%jd.%02d",
> (intmax_t)start_time.tv_sec,(int)start_time.tv_usec/10000);
... yet you do it here. I think the first occurrence is missing the
cast?
Thanks, Roger.
