On Wed, Dec 09, 2020 at 04:54:51PM +0100, Olaf Hering wrote: > Introduce new API to test if a fixed number of bits is clear or set, > and clear or set them all at once. > > The caller has to make sure the input bitnumber is a multiply of > BITS_PER_LONG. > > This API avoids the loop over each bit in a known range just to see > if all of them are either clear or set. > > Signed-off-by: Olaf Hering <[email protected]>
I would rather these be introduced along side their callers. > --- > tools/libs/ctrl/xc_bitops.h | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/tools/libs/ctrl/xc_bitops.h b/tools/libs/ctrl/xc_bitops.h > index f0bac4a071..92f38872fb 100644 > --- a/tools/libs/ctrl/xc_bitops.h > +++ b/tools/libs/ctrl/xc_bitops.h > @@ -77,4 +77,29 @@ static inline void bitmap_or(void *_dst, const void > *_other, > dst[i] |= other[i]; > } > > +static inline int test_bit_long_set(unsigned long nr_base, const void *_addr) What's wrong with requiring the input addr be const unsigned long *?
