On 07/12/2020 10:36, Rahul Singh wrote:
I would implement it in include/xen/compiler.h.
Ok. I will implement and will share the patch for “__attribute__((__fallthrough__))
” but for SMMUv3 is that ok if we can proceed with “ /* fallthrough */ ".
The first approach should always be to work with the community to
introduce such functionality tree-wide. Note that I am not suggesting to
replace existing "/* fallthrough */" with "fallthrough".
If it is taking too long or the task is significant, then we can discuss
about way to temporally work around it.
I don't believe we are at that stage yet here.
As “fallthorugh” implementation is common for all architecture it required
review for all stakeholder as per my understanding. I don’t want to block
SMMUv3 because of this.
It only requires review from "THE REST" maintainers.
Cheers,
--
Julien Grall
