Hello ,

> On 24 Nov 2020, at 12:11 am, Stefano Stabellini <[email protected]> 
> wrote:
> 
> On Mon, 23 Nov 2020, Jan Beulich wrote:
>> There's no point wrapping the function invocation when
>> - the function body is already suitably wrapped,
>> - the function itself is unconditionally available.
>> 
>> Reported-by: Julien Grall <[email protected]>
>> Signed-off-by: Jan Beulich <[email protected]>
> 
> Reviewed-by: Stefano Stabellini <[email protected]>
> 
Reviewed-by: Rahul Singh <[email protected]>
> 
>> --- a/xen/drivers/char/ns16550.c
>> +++ b/xen/drivers/char/ns16550.c
>> @@ -662,9 +662,7 @@ static int __init check_existence(struct
>>     return 1; /* Everything is MMIO */
>> #endif
>> 
>> -#ifdef CONFIG_HAS_PCI
>>     pci_serial_early_init(uart);
>> -#endif
>> 
>>     /*
>>      * Do a simple existence test first; if we fail this,
>> 
> 

Regards,
Rahul

Reply via email to