> -----Original Message-----
> From: Andrew Cooper <[email protected]>
> Sent: 23 November 2020 22:18
> To: Paul Durrant <[email protected]>; [email protected]
> Cc: Paul Durrant <[email protected]>; Anthony PERARD
> <[email protected]>; Christian Lindig
> <[email protected]>; David Scott <[email protected]>; George Dunlap
> <[email protected]>; Ian Jackson <[email protected]>; Nick Rosbrook
> <[email protected]>;
> Wei Liu <[email protected]>
> Subject: Re: [PATCH v3 00/23] xl / libxl: named PCI pass-through devices
>
> On 23/11/2020 17:44, Paul Durrant wrote:
> > From: Paul Durrant <[email protected]>
> >
> > Paul Durrant (23):
> > xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
> > libxl: make libxl__device_list() work correctly for
> > LIBXL__DEVICE_KIND_PCI...
> > libxl: Make sure devices added by pci-attach are reflected in the
> > config
> > libxl: add/recover 'rdm_policy' to/from PCI backend in xenstore
> > libxl: s/detatched/detached in libxl_pci.c
> > libxl: remove extraneous arguments to do_pci_remove() in libxl_pci.c
> > libxl: stop using aodev->device_config in libxl__device_pci_add()...
> > libxl: generalise 'driver_path' xenstore access functions in
> > libxl_pci.c
> > libxl: remove unnecessary check from libxl__device_pci_add()
> > libxl: remove get_all_assigned_devices() from libxl_pci.c
> > libxl: make sure callers of libxl_device_pci_list() free the list
> > after use
> > libxl: add libxl_device_pci_assignable_list_free()...
> > libxl: use COMPARE_PCI() macro is_pci_in_array()...
> > docs/man: extract documentation of PCI_SPEC_STRING from the xl.cfg
> > manpage...
> > docs/man: improve documentation of PCI_SPEC_STRING...
> > docs/man: fix xl(1) documentation for 'pci' operations
> > libxl: introduce 'libxl_pci_bdf' in the idl...
> > libxlu: introduce xlu_pci_parse_spec_string()
> > libxl: modify
> > libxl_device_pci_assignable_add/remove/list/list_free()...
> > docs/man: modify xl(1) in preparation for naming of assignable devices
> > xl / libxl: support naming of assignable devices
> > docs/man: modify xl-pci-configuration(5) to add 'name' field to
> > PCI_SPEC_STRING
> > xl / libxl: support 'xl pci-attach/detach' by name
>
> We're trying to get the CI loop up and running. Its not emailing
> xen-devel yet, but has found a real error somewhere in this series.
>
> https://gitlab.com/xen-project/patchew/xen/-/pipelines/220153571
>
Found it, thanks...
libxl_pci.c: In function 'libxl_device_pci_assignable_name2bdf':
libxl_pci.c:970:5: error: 'pcibdf' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
return pcibdf;
^
Odd that my local build (debian 9.13) didn't pick it up. Will send a v4 shortly.
Paul
> ~Andrew
