> -----Original Message----- > From: Jan Beulich <[email protected]> > Sent: 12 November 2020 09:23 > To: Paul Durrant <[email protected]> > Cc: Paul Durrant <[email protected]>; Wei Liu <[email protected]>; Andrew Cooper > <[email protected]>; Roger Pau Monné <[email protected]>; > [email protected] > Subject: Re: [PATCH 08/10] viridian: log initial invocation of each type of > hypercall > > On 11.11.2020 21:07, Paul Durrant wrote: > > --- a/xen/include/asm-x86/hvm/viridian.h > > +++ b/xen/include/asm-x86/hvm/viridian.h > > @@ -59,6 +59,14 @@ struct viridian_domain > > { > > union hv_guest_os_id guest_os_id; > > union hv_vp_assist_page_msr hypercall_gpa; > > + unsigned long hypercall_flags; > > + > > +#define _HCALL_spin_wait 0 > > +#define _HCALL_flush 1 > > +#define _HCALL_flush_ex 2 > > +#define _HCALL_ipi 3 > > +#define _HCALL_ipi_ex 4 > > I'd like to suggest for this to either be unsigned int until > more than 32 bits are needed, or be using DECLARE_BITMAP() > right away.
Ok. I may just go straight for the bitmap then. Paul > > Jan
