On 18.11.2020 18:06, Julien Grall wrote: > On 23/10/2020 11:17, Jan Beulich wrote: >> In order to (subsequently) drop odd things like CONFIG_NEEDS_LIST_SORT >> just to avoid bloating binaries when only some arch-es and/or >> configurations need generic library routines, combine objects under lib/ >> into an archive, which the linker then can pick the necessary objects >> out of. >> >> Note that we can't use thin archives just yet, until we've raised the >> minimum required binutils version suitably. >> >> Signed-off-by: Jan Beulich <[email protected]> >> --- >> xen/Rules.mk | 33 +++++++++++++++++++++++++++------ >> xen/arch/arm/Makefile | 6 +++--- >> xen/arch/x86/Makefile | 8 ++++---- >> xen/lib/Makefile | 3 ++- > > IIRC, Anthony worked on the build systems. If I am right, it would be > good to get a review from him.
I'll try to remember next time round. >> --- a/xen/lib/Makefile >> +++ b/xen/lib/Makefile >> @@ -1,2 +1,3 @@ >> -obj-y += ctype.o >> obj-$(CONFIG_X86) += x86/ >> + >> +lib-y += ctype.o > > May I ask why all the code movement by ctype was done after this patch? I'm sorry, but I'm afraid I don't understand the question. Jan
