> -----Original Message----- > From: Jan Beulich <[email protected]> > Sent: 12 November 2020 11:45 > To: Oleksandr Tyshchenko <[email protected]>; Paul Durrant <[email protected]> > Cc: Oleksandr Tyshchenko <[email protected]>; Andrew Cooper > <[email protected]>; > Roger Pau Monné <[email protected]>; Wei Liu <[email protected]>; George Dunlap > <[email protected]>; Ian Jackson <[email protected]>; Julien Grall > <[email protected]>; Stefano > Stabellini <[email protected]>; Jun Nakajima <[email protected]>; > Kevin Tian > <[email protected]>; Julien Grall <[email protected]>; > [email protected] > Subject: Re: [PATCH V2 12/23] xen/ioreq: Remove "hvm" prefixes from involved > function names > > On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: > > From: Oleksandr Tyshchenko <[email protected]> > > > > This patch removes "hvm" prefixes and infixes from IOREQ > > related function names in the common code. > > AT least some of the functions touched here would be nice to be > moved to a more consistent new naming scheme right away, to > avoid having to touch all the same places again. I guess ioreq > server functions would be nice to all start with ioreq_server_ > and ioreq functions to all start with ioreq_. E.g. ioreq_send() > and ioreq_server_select(). > > Paul, thoughts? >
Yes, that sounds like a good idea. Obviously the code has grown a little organically so some naming cleanup is welcome. Paul > Jan
