On 20.10.20 13:55, Paul Durrant wrote:
Hi Paul.
Sorry for the late response.
-----Original Message-----
From: Oleksandr Tyshchenko <[email protected]>
Sent: 15 October 2020 17:44
To: [email protected]
Cc: Oleksandr Tyshchenko <[email protected]>; Paul Durrant
<[email protected]>; Jan Beulich
<[email protected]>; Andrew Cooper <[email protected]>; Roger Pau Monné
<[email protected]>; Wei Liu <[email protected]>; George Dunlap
<[email protected]>; Ian Jackson
<[email protected]>; Julien Grall <[email protected]>; Stefano Stabellini
<[email protected]>; Jun
Nakajima <[email protected]>; Kevin Tian <[email protected]>; Julien
Grall
<[email protected]>
Subject: [PATCH V2 11/23] xen/ioreq: Move x86's io_completion/io_req fields to
struct vcpu
From: Oleksandr Tyshchenko <[email protected]>
The IOREQ is a common feature now and these fields will be used
on Arm as is. Move them to common struct vcpu as a part of new
struct vcpu_io. Also move enum hvm_io_completion to xen/sched.h
and remove "hvm" prefixes.
This patch completely removes layering violation in the common code.
Signed-off-by: Oleksandr Tyshchenko <[email protected]>
CC: Julien Grall <[email protected]>
---
Please note, this is a split/cleanup/hardening of Julien's PoC:
"Add support for Guest IO forwarding to a device emulator"
***
I was thinking that it may be better to place these two fields
into struct vcpu directly (without intermediate "io" struct).
I think, this way the code which operates with these fields
would become cleaner. Another possible option would be either
to rename "io" struct (I failed to think of a better name) or
to drop(replace?) duplicating "io" prefixes from these fields.
Just drop the 'io_' prefix from the field names.
Will drop. This would look like indeed better.
Thank you.
--
Regards,
Oleksandr Tyshchenko
