On Wed, Sep 16, 2020 at 08:34:10PM +0200, David Hildenbrand wrote: > Page isolation doesn't actually touch the pages, it simply isolates > pageblocks and moves all free pages to the MIGRATE_ISOLATE freelist. > > We already place pages to the tail of the freelists when undoing > isolation via __putback_isolated_page(), let's do it in any case > (e.g., if order == pageblock_order) and document the behavior. > > This change results in all pages getting onlined via online_pages() to > be placed to the tail of the freelist. > > Cc: Andrew Morton <[email protected]> > Cc: Alexander Duyck <[email protected]> > Cc: Mel Gorman <[email protected]> > Cc: Michal Hocko <[email protected]> > Cc: Dave Hansen <[email protected]> > Cc: Vlastimil Babka <[email protected]> > Cc: Wei Yang <[email protected]> > Cc: Oscar Salvador <[email protected]> > Cc: Mike Rapoport <[email protected]> > Cc: Scott Cheloha <[email protected]> > Cc: Michael Ellerman <[email protected]> > Signed-off-by: David Hildenbrand <[email protected]>
LGTM. Feel the same way about move_freepages_block_tail/move_freepages_block_tail wrappers, I think we are better off without them. Reviewed-by: Oscar Salvador <[email protected]> Thanks -- Oscar Salvador SUSE L3
