On Thursday, September 17, 2020 9:04 AM, Trammell Hudson <[email protected]> wrote: > On Thursday, September 17, 2020 8:33 AM, Jan Beulich [email protected] wrote: > > [...] > > > - if ( read_section(image, ".ucode", &ucode, NULL) ) > > > - return; > > > > > > - name.s = get_value(&cfg, section, "ucode"); > > > > With the Arm change already in mind and with further similar > > changes further down, may I suggest to consider passing > > 'section' into read_section(), thus guaranteeing consistent > > naming between image section and config file items, not only now > > but also going forward? read_section() would then check for the > > leading dot followed by the specified name. > > That could work, I think. Let me test it out for v5.
Or maybe not. section is the "section-name" of the config file that is being booted: [global] default=section-name Meanwhile, read_section() wants the PE section name, like ".ucode", which might appear as a line item in that section. -- Trammell
